feat(logger): Use console methods respective to log level #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2025
lforst
approved these changes
Jan 13, 2025
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 15, 2025
| datasource | package | from | to | | ---------- | ------------------- | ------ | ----- | | npm | @sentry/vite-plugin | 2.23.0 | 3.0.0 | ## [v3.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#300) ##### Breaking Changes - Injected code will now use `let`, which was added in ES6 (ES2015). This means that ES6 is the minimum JavaScript version that the Sentry bundler plugins support. - Deprecated options have been removed: - `deleteFilesAfterUpload` - Use `filesToDeleteAfterUpload` instead - `bundleSizeOptimizations.excludePerformanceMonitoring` - Use `bundleSizeOptimizations.excludeTracing` instead - `_experiments.moduleMetadata` - Use `moduleMetadata` instead - `cleanArtifacts` - Did not do anything ##### List of Changes - fix!: Wrap injected code in block-statement to contain scope ([#646](getsentry/sentry-javascript-bundler-plugins#646)) - chore!: Remove deprecated options ([#654](getsentry/sentry-javascript-bundler-plugins#654)) - feat(logger): Use console methods respective to log level ([#652](getsentry/sentry-javascript-bundler-plugins#652)) - fix(webpack): Ensure process exits when done ([#653](getsentry/sentry-javascript-bundler-plugins#653)) - fix: Use correct replacement matcher for `bundleSizeOptimizations.excludeTracing` ([#644](getsentry/sentry-javascript-bundler-plugins#644)) Work in this release contributed by [@jdelStrother](https://github.com/jdelStrother). Thank you for your contribution!
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 15, 2025
| datasource | package | from | to | | ---------- | ------------------- | ------ | ----- | | npm | @sentry/vite-plugin | 2.23.0 | 3.0.0 | ## [v3.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#300) ##### Breaking Changes - Injected code will now use `let`, which was added in ES6 (ES2015). This means that ES6 is the minimum JavaScript version that the Sentry bundler plugins support. - Deprecated options have been removed: - `deleteFilesAfterUpload` - Use `filesToDeleteAfterUpload` instead - `bundleSizeOptimizations.excludePerformanceMonitoring` - Use `bundleSizeOptimizations.excludeTracing` instead - `_experiments.moduleMetadata` - Use `moduleMetadata` instead - `cleanArtifacts` - Did not do anything ##### List of Changes - fix!: Wrap injected code in block-statement to contain scope ([#646](getsentry/sentry-javascript-bundler-plugins#646)) - chore!: Remove deprecated options ([#654](getsentry/sentry-javascript-bundler-plugins#654)) - feat(logger): Use console methods respective to log level ([#652](getsentry/sentry-javascript-bundler-plugins#652)) - fix(webpack): Ensure process exits when done ([#653](getsentry/sentry-javascript-bundler-plugins#653)) - fix: Use correct replacement matcher for `bundleSizeOptimizations.excludeTracing` ([#644](getsentry/sentry-javascript-bundler-plugins#644)) Work in this release contributed by [@jdelStrother](https://github.com/jdelStrother). Thank you for your contribution!
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 17, 2025
| datasource | package | from | to | | ---------- | ------------------- | ------ | ----- | | npm | @sentry/vite-plugin | 2.23.0 | 3.0.0 | ## [v3.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#300) ##### Breaking Changes - Injected code will now use `let`, which was added in ES6 (ES2015). This means that ES6 is the minimum JavaScript version that the Sentry bundler plugins support. - Deprecated options have been removed: - `deleteFilesAfterUpload` - Use `filesToDeleteAfterUpload` instead - `bundleSizeOptimizations.excludePerformanceMonitoring` - Use `bundleSizeOptimizations.excludeTracing` instead - `_experiments.moduleMetadata` - Use `moduleMetadata` instead - `cleanArtifacts` - Did not do anything ##### List of Changes - fix!: Wrap injected code in block-statement to contain scope ([#646](getsentry/sentry-javascript-bundler-plugins#646)) - chore!: Remove deprecated options ([#654](getsentry/sentry-javascript-bundler-plugins#654)) - feat(logger): Use console methods respective to log level ([#652](getsentry/sentry-javascript-bundler-plugins#652)) - fix(webpack): Ensure process exits when done ([#653](getsentry/sentry-javascript-bundler-plugins#653)) - fix: Use correct replacement matcher for `bundleSizeOptimizations.excludeTracing` ([#644](getsentry/sentry-javascript-bundler-plugins#644)) Work in this release contributed by [@jdelStrother](https://github.com/jdelStrother). Thank you for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All log levels were directed to
stderrhere: #624However, this also can lead to problems as other frameworks like Nuxt prettify the console output and attach text like
ERRORto the output as described in this issue: getsentry/sentry-javascript#14879The issue reported with knip occurs because knip only writes valid JSON to
stdout. The change in this PR should not re-introduce this error as knip was failing because of a warning (which is directed tostderr). If anyone still experience problems, you can setsilent: true.closes getsentry/sentry-javascript#14879